Skip to content

Add a lookbook example for loading inline macros#23876

Merged
NobodysNightmare merged 1 commit into
release/17.6from
loading-inline-macro
Jun 25, 2026
Merged

Add a lookbook example for loading inline macros#23876
NobodysNightmare merged 1 commit into
release/17.6from
loading-inline-macro

Conversation

@NobodysNightmare

@NobodysNightmare NobodysNightmare commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

We discussed this during a UX meeting today and it can't hurt to document this as a specific case, because we might have multiple implementations that need to behave like that.

Screenshot

image

@NobodysNightmare NobodysNightmare requested a review from HDinger June 23, 2026 08:39
@NobodysNightmare

NobodysNightmare commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Note that I am slightly surprised by the bad vertical alignment.

Though this seems to be large caused by the spinner itself being ill-aligned:

image

@Kharonus

Kharonus commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

nice 🚀 can the vertical alignment get fixed?

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/my_page/spec/features/my/work_package_table_spec.rb[1:1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #23876, linked for reference only):

- `rspec ./modules/my_page/spec/features/my/work_package_table_spec.rb[1:1:1]`

Treat this as a standalone task, unrelated to PR #23876. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #23876 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @NobodysNightmare to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @NobodysNightmare, and request a review from @NobodysNightmare.
On every commit, set @NobodysNightmare as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@NobodysNightmare

NobodysNightmare commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Note that I am slightly surprised by the bad vertical alignment.

So a "fix" seems to be to add vertical-align: center to the SVG that's wrapped inside the component span. However, that's something I can't really change, because I have no access to the components source code...

I'd probably accept this for now.

HDinger
HDinger reviewed Jun 24, 2026
View reviewed changes
Comment thread lookbook/previews/op_primer/inline_macro_component_preview/loading_content.html.erb Outdated
<%= render(OpPrimer::InlineMacroComponent.new) do |c| %>
<% c.with_leading_visual_icon(icon: :book) %>

<%= render(Primer::Beta::Spinner.new(size: :small, mr: 2, sr_text: "")) %>

@HDinger HDinger Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should fix the alignment issue

Suggested change
<%= render(Primer::Beta::Spinner.new(size: :small, mr: 2, sr_text: "")) %>
<%= render(Primer::Beta::Spinner.new(size: :small, display: :flex, mr: 2, sr_text: "")) %>

@NobodysNightmare NobodysNightmare Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@NobodysNightmare
Add a lookbook example for loading inline macros
028b035 
We discussed this during a UX meeting today and it can't hurt to
document this as a specific case, because we might have multiple implementations
that need to behave like that.
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

Warning

This pull request does not link an OpenProject work package.

Please add a link to the work package in the description, or reference it in the
title in square brackets, e.g. [SLUG-123] My title here.

@NobodysNightmare NobodysNightmare requested a review from HDinger June 24, 2026 13:48
@NobodysNightmare NobodysNightmare merged commit c40f444 into release/17.6 Jun 25, 2026
15 checks passed
@NobodysNightmare NobodysNightmare deleted the loading-inline-macro branch June 25, 2026 07:12
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HDinger HDinger HDinger approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NobodysNightmare @Kharonus @HDinger